adding Dropbox OAuth #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdmcnair
commented
Jan 17, 2018
| @@ -135,6 +159,9 @@ export function loginViaAuthorizationCodeFlow(credentials: TnsOAuthModule.ITnsOA | |||
| let errSubCode = qsObj['error_subcode']; | |||
| if (codeStr) { | |||
| try { | |||
| if(credentials.skipNextTokenNav && tokenNavStarted) return true; | |||
There was a problem hiding this comment.
We had a second call to checkCodeIntercept that was happening within the shouldOverrideUrlLoading method of the webview helper. Dropbox was returning an error because the code had already been used to receive a token by that point. I don't know if that would be an issue for other OAuth providers as well, but I've corrected it here using the skipNextTokenNav property, which currently only the Dropbox provider uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dropbbox OAuth functionality. This implied a need to allow individual
AuthHelpers to opt out of certain parameters to the provider, because Dropbox rejects theresponse_modeandnonceparameters on the Auth endpoint, and rejects theresponse_mode,nonce, andstateparameters on the token endpoint. Added functionality to that effect intns-oauth.ts.See the note on
tns-oauth.tsabout an additional bug I fixed for the Dropbox auth helper that may possibly be useful for other auth providers.