Security Patch: Harden upload and rename to prevent RCE (Fixes #408) #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mai#408) This PR hardens the `upload()` and `rename()` functions to fix the critical security vulnerabilities discussed in Issue alexusmai#408. **1. Rename Vulnerability (Vulnerability 2):** The `rename()` method now validates the new file extension against the `allowFileTypes` config list. This directly prevents renaming a file like `image.jpg` to `shell.php`. **2. Disguised Upload Vulnerability:** The `upload()` method has been significantly hardened and no longer trusts the file extension alone. The new validation logic includes: * **MIME Type Validation:** Uses `finfo_file` to get the true MIME type. * **PHP Payload Scanning:** Scans file content for PHP tags (e.g., `<?php`) if PHP is not an explicitly allowed extension. * **Magic Byte Validation:** Validates file headers for common types (images, PDFs, Zip, etc.) to ensure the content matches the extension. This patch blocks the reported RCE vectors by ensuring only genuinely safe and allowed files can be uploaded or renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hardens the
upload()andrename()functions to fix the critical security vulnerabilities discussed in Issue #408.1. Rename Vulnerability (Vulnerability 2):
The
rename()method now validates the new file extension against theallowFileTypesconfig list. This directly prevents renaming a file likeimage.jpgtoshell.php.2. Disguised Upload Vulnerability:
The
upload()method has been significantly hardened and no longer trusts the file extension alone. The new validation logic includes:finfo_fileto get the true MIME type.<?php) if PHP is not an explicitly allowed extension.This patch blocks the reported RCE vectors by ensuring only genuinely safe and allowed files can be uploaded or renamed.