Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug with conflicts #2

Merged
merged 1 commit into from
Nov 11, 2021
Merged

fix: bug with conflicts #2

merged 1 commit into from
Nov 11, 2021

Conversation

okdistribute
Copy link
Contributor

@okdistribute okdistribute commented Nov 11, 2021

This is actually broken on the latest automerge (my fault: #1)

To reproduce:

  1. Open two browsers
  2. Add remote http://127.0.0.1:5000/groceries
  3. Add some items to todo list on both sides
  4. Hit 'push' on one side
  5. Hit 'fetch' on the other
new.js:1536 Uncaught (in promise) RangeError: Expected seq 3, got seq 2 from actor 0000
    at applyChanges (new.js:1536)
    at BackendDoc.applyChanges (new.js:1778)
    at Object.applyChanges (backend.js:29)
    at Object.applyChanges (automerge.js:93)
    at AutomergeTodos.<anonymous> (automerge_hooks.ts:85)
    at Generator.next (<anonymous>)
    at tslib.es6.js:74
    at new Promise (<anonymous>)
    at __awaiter (tslib.es6.js:70)
    at AutomergeTodos.applyChanges (automerge_hooks.ts:82)

New changes should fix this.

Also looking at making this part of the automerge library, this explains the issue: automerge/automerge#374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants