Better error coverage 2 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed-by: honkar, prr
Reviewed-by: wkemper
…rash Co-authored-by: Richard Reingruber <[email protected]> Reviewed-by: pchilanomate, rrich, vlivanov, never
Reviewed-by: kvn, sviswanathan
Reviewed-by: fjiang, mli
…med out Reviewed-by: thartmann
Co-authored-by: Severin Gehwolf <[email protected]> Reviewed-by: sgehwolf, mbaesken
Reviewed-by: dholmes, clanger
Reviewed-by: dholmes, iklam
Reviewed-by: dfuchs, myankelevich
…ning tests if multiple tests have the same description
…gBundle.cannedFormattedString()
…rmattedString.CannedArgument interface to make CannedFormattedString instances provide system-independent test descriptions.
…t --name option but with --runtime-image option. Allow to use arguments with CannedFormattedString that get their values from JPackageCommand instance. Make JPackageCommand.validateOutput(CannedFormattedString) more robust and allow it to take an array of canned formatted strings.
…ype(); Add PackageType.isEnabled(). Make PackageType.isEnabled() and PackageType.isSupported() public.
alexeysemenyukoracle
force-pushed
the
better-error-coverage-2
branch
from
d3a3551 to
67cbfb0
Compare
…non-empty directory
…r tests covering `--runtime-image` option and the negative test duplicates a test in ErrorTest (the one covering ERR_MacAppStoreRuntimeBinExists)
…rTest test cases: '--mac-sign option is required' -> 'error.app-image.mac-sign.required'; 'Option [--mac-app-store] is not valid' -> 'ERR_InvalidOptionWithAppImageSigning'.
…mmands(). It duplicates `ERR_MissingJLinkOptMacAppStore` test case in ErrorTest
…t and is less strict on analyzing error output
…e runtime is used
…ame from the runtime image directory name if `--name` option is not given
…p versions better, it verifies error messages in jpackage output, AppVersionTest doesn't.
…n command file is no found. Instead it throws `java.nio.file.NoSuchFileException`.
…no-input-parameter" as the error is not missing argument of `--input` parameter, but missing `--input` parameter itself.
alexeysemenyukoracle
force-pushed
the
better-error-coverage-2
branch
from
67cbfb0 to
dc5974f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.