Skip to content

Aleph 565 ipv4 domain support #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Jun 18, 2025

Add domain support via HaProxy

Related ClickUp, GitHub or Jira tickets : ALEPH-565

This PR doesn't handle redirect to the CRN itself at the moment. You need to change the Caddy config to use another port 4443

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

How to test

Setup To test:
On crn

  • Rename /etc/haproxy/haproxy-aleph.cfg to /etc/haproxy/haproxy.cfg to activate it's config
  • Restart haproxy : sudo systemctl restart haproxy

Deploy an instance
Inside instanceInstall nginx inside it.
Choose a domain name. e.g. echo.agot.be
For https Generate a self signed certificate and config nginx to use it.
If you didn't update your dns, force the domain name by update your /etc/hosts

127.0.0.1 localhost echo.agot.be

To test https via curl:
curl -k -v https://echo.agot.be:443

  • -k is to allow the self signed certificate

To test http
curl -v http://echo.agot.be:443

@olethanh olethanh changed the title Ol aleph 565 ipv4 domain support Aleph 565 ipv4 domain support Jun 24, 2025
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 20.60302% with 158 lines in your changes missing coverage. Please review.

Project coverage is 64.15%. Comparing base (f6d5a24) to head (8e6097c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/haproxy.py 17.74% 153 Missing ⚠️
src/aleph/vm/pool.py 54.54% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   65.27%   64.15%   -1.12%     
==========================================
  Files          85       86       +1     
  Lines        7685     7883     +198     
  Branches      664      698      +34     
==========================================
+ Hits         5016     5057      +41     
- Misses       2460     2616     +156     
- Partials      209      210       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@olethanh olethanh force-pushed the ol-aleph-565-ipv4-domain-support branch from 735136f to 7cc688b Compare June 25, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant