-
Notifications
You must be signed in to change notification settings - Fork 19
Aleph 565 ipv4 domain support #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
olethanh
wants to merge
20
commits into
main
Choose a base branch
from
ol-aleph-565-ipv4-domain-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP imported from devops POC
Might need to move it to Recomands instead
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
==========================================
- Coverage 65.27% 64.15% -1.12%
==========================================
Files 85 86 +1
Lines 7685 7883 +198
Branches 664 698 +34
==========================================
+ Hits 5016 5057 +41
- Misses 2460 2616 +156
- Partials 209 210 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
735136f
to
7cc688b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add domain support via HaProxy
Related ClickUp, GitHub or Jira tickets : ALEPH-565
This PR doesn't handle redirect to the CRN itself at the moment. You need to change the Caddy config to use another port 4443
Self proofreading checklist
packaging/Makefile
How to test
Setup To test:
On crn
/etc/haproxy/haproxy-aleph.cfg
to/etc/haproxy/haproxy.cfg
to activate it's configsudo systemctl restart haproxy
Deploy an instance
Inside instanceInstall nginx inside it.
Choose a domain name. e.g. echo.agot.be
For https Generate a self signed certificate and config nginx to use it.
If you didn't update your dns, force the domain name by update your /etc/hosts
To test https via curl:
curl -k -v https://echo.agot.be:443
-k
is to allow the self signed certificateTo test http
curl -v http://echo.agot.be:443