ALEPH-512 ensure we always return json for error #804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some endpoint return text for errors which made the web frontend crash Solution: Add a middleware which ensure a json error is always returned Add some test for it
Use a signal instead of a middleware to add the 'Server' version header as in some case (StreamResponse, Websocket) it would not work and display warning see: https://docs.aiohttp.org/en/stable/web_advanced.html#signals
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 64.57% 64.88% +0.30%
==========================================
Files 78 79 +1
Lines 7094 7133 +39
Branches 598 601 +3
==========================================
+ Hits 4581 4628 +47
+ Misses 2313 2304 -9
- Partials 200 201 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some endpoint return text for errors which made the web frontend crash
Solution: Add a middleware which ensure a json error is always returned
Add some test for it.
Also refactor version header code
Related ClickUp, GitHub or Jira tickets : ALEPH-512
Self proofreading checklist
packaging/MakefileHow to test
Call multiple endpoint, try to trigger error