Skip to content

New capability endpoint to add CPU information (model, vendor, frequency) and memory details (clock, size, type) to API #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 26, 2025

Conversation

olethanh
Copy link
Collaborator

@olethanh olethanh commented Apr 22, 2025

Add /about/capability endpoint
Related ClickUp, GitHub or Jira tickets : ALEPH-522
Replace #544

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.
  • Dependencies update in the project.toml have been mirrored in the Debian package build script packaging/Makefile

@olethanh olethanh force-pushed the ol-522-capability-endpoint branch from fa1405a to 04b4101 Compare April 22, 2025 13:14
@olethanh olethanh force-pushed the ol-522-capability-endpoint branch 5 times, most recently from 5fc4735 to 66558c8 Compare May 7, 2025 08:39
@olethanh olethanh marked this pull request as ready for review May 7, 2025 13:59
@olethanh olethanh changed the title Ol 522 capability endpoint Add capability endpoint May 7, 2025
@olethanh olethanh changed the title Add capability endpoint New capability endpoint to add CPU information (model, vendor, frequency) and memory details (clock, size, type) to API May 7, 2025
@olethanh olethanh requested a review from nesitor May 7, 2025 14:05
@olethanh olethanh force-pushed the ol-522-capability-endpoint branch from 07a5d14 to 20dc30d Compare May 8, 2025 09:06
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 79.66102% with 24 lines in your changes missing coverage. Please review.

Project coverage is 65.49%. Comparing base (8eebffa) to head (03a1943).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/aleph/vm/orchestrator/machine.py 50.00% 17 Missing and 5 partials ⚠️
tests/supervisor/test_views.py 93.75% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #801      +/-   ##
==========================================
+ Coverage   65.30%   65.49%   +0.19%     
==========================================
  Files          79       80       +1     
  Lines        7220     7330     +110     
  Branches      602      614      +12     
==========================================
+ Hits         4715     4801      +86     
- Misses       2311     2329      +18     
- Partials      194      200       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aliel and others added 8 commits May 19, 2025 15:26
…cpuinfo

Add CPU information (model, vendor, frequency) and memory details (clock, size, type) to API
… concurrency

avoid Try-Catch using assertions
Solution: Introduce our own decorator
it's not really important but it was somehow annoying me
@olethanh olethanh force-pushed the ol-522-capability-endpoint branch from 20dc30d to 855da0e Compare May 19, 2025 13:28
@olethanh olethanh force-pushed the ol-522-capability-endpoint branch from 855da0e to 03a1943 Compare May 20, 2025 07:01
@olethanh olethanh requested a review from nesitor May 20, 2025 09:02
@nesitor nesitor merged commit 7865b42 into main May 26, 2025
22 checks passed
@nesitor nesitor deleted the ol-522-capability-endpoint branch May 26, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants