-
Notifications
You must be signed in to change notification settings - Fork 19
Retry instances not running add new Execution list endpoint #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
olethanh
wants to merge
18
commits into
main
Choose a base branch
from
ol-ALEPH-287-retry-instance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7694fb3
to
f5d096f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
+ Coverage 64.54% 65.02% +0.48%
==========================================
Files 78 78
Lines 7093 7180 +87
Branches 598 599 +1
==========================================
+ Hits 4578 4669 +91
- Misses 2315 2318 +3
+ Partials 200 193 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f5d096f
to
f38053f
Compare
I will rework the commit cleanly and update the desc but for me this is ready for review |
50c0f9b
to
637df1a
Compare
b4f1398
to
d50c807
Compare
d50c807
to
e5ec35a
Compare
mod: VmPool remove unused loop argument
Wait for boot, clean up ressources if boot failed
Add a new executions list endpoint with more information on the state of the VM to be used by client so we can better inform them on their instance state This new endpoint list all executions in pool running or not (but terminated VM are removed from the pool)
Handle VM that are stopping and starting before creating a new one
Prevent the case when the VM was not stopped when running execution.stop() directly instead of VmPool.stop_vm() Simplify code, add warning
Change sig of enable_and_start to async Adapt Firecracker instance test - Rename to test_create_firecracker_instance - Use mocker to patch() settings so it doesn't contamine other tests - Ensure it ping properly to confirm it is working
e5ec35a
to
9f1acdd
Compare
nesitor
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ALEPH-287
This PR improve how Instance are started, making it more reliable and properly cleaning when they fail to start. It also allow to start again the VM if it failed to start the first time.
Changes introduced by this PR:
/v2/about/executions/list
which also include the starting, started, end times etc.. so we can inspect the VM state. and includ non running VM It will allow us in the future to improve the clientsSelf proofreading checklist
packaging/Makefile
Changes
In addition to what was listed above, others refactor changes:
How to test
Allocate VM, try allocating VM that fail to start and reallocate again. Kill VM during boot