fix(utils): Removed forced path for mksquashfs #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chuipagro
approved these changes
May 19, 2025
nesitor
approved these changes
Jun 26, 2025
|
@nesitor small bump to merge this ;) |
@RezaRahemtola the PR is not passing the CI tests and either the code quality rules. Code quality can be solved easily with the command |
Indeed, will try to check when I have some time, for now I kept these changes locally so it works for the use cases I have on mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with
aleph program uploadon operating systems wheremksquashfsis not installed at this location (eg on MacOS with homebrew it's at/opt/homebrew/bin/mksquashfs, and/usr/binis not writable without disabling important security features of the OS).Letting the OS figures out the location of the binary to use fixes this & works for everybody.
Print screen / video
Before:
After:
