Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: instrument tracer for async_trait calls #1031

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

andysim3d
Copy link
Collaborator

[Closes/Fixes]

Proposed Changes

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 36.19048% with 67 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/otlp-instrument@5c91c60). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/provider/src/alloy/evm.rs 5.55% 17 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_7.rs 0.00% 9 Missing ⚠️
crates/sim/src/precheck.rs 0.00% 9 Missing ⚠️
crates/provider/src/alloy/entry_point/v0_6.rs 0.00% 7 Missing ⚠️
crates/provider/src/alloy/da/local/bedrock.rs 0.00% 6 Missing ⚠️
crates/rpc/src/eth/api.rs 28.57% 5 Missing ⚠️
crates/sim/src/gas/gas.rs 20.00% 4 Missing ⚠️
crates/provider/src/alloy/da/local/nitro.rs 0.00% 3 Missing ⚠️
crates/rpc/src/eth/events/common.rs 50.00% 2 Missing ⚠️
crates/pool/src/chain.rs 83.33% 1 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/paymaster.rs 93.24% <100.00%> (ø)
crates/rpc/src/eth/events/mod.rs 100.00% <100.00%> (ø)
crates/sim/src/estimation/estimate_call_gas.rs 86.88% <100.00%> (ø)
...es/sim/src/estimation/estimate_verification_gas.rs 84.69% <100.00%> (ø)
crates/sim/src/estimation/v0_6.rs 94.64% <100.00%> (ø)
crates/sim/src/estimation/v0_7.rs 89.32% <100.00%> (ø)
crates/sim/src/gas/oracle.rs 91.74% <100.00%> (ø)
crates/pool/src/chain.rs 95.93% <83.33%> (ø)
crates/pool/src/mempool/uo_pool.rs 93.31% <75.00%> (ø)
crates/provider/src/alloy/da/arbitrum.rs 0.00% <0.00%> (ø)
... and 11 more
Flag Coverage Δ
unit-tests 59.71% <36.19%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (?)
builder 67.64% <0.00%> (?)
dev ∅ <0.00%> (?)
pool 67.75% <0.00%> (?)
provider 19.81% <0.00%> (?)
rpc 25.85% <0.00%> (?)
sim 80.16% <0.00%> (?)
tasks ∅ <0.00%> (?)
types 66.80% <0.00%> (?)
utils 32.43% <0.00%> (?)

@andysim3d andysim3d marked this pull request as draft February 21, 2025 23:55
@andysim3d andysim3d force-pushed the andy/otlp-instrument branch 3 times, most recently from 80f79d1 to 560f47b Compare February 24, 2025 19:04
@andysim3d andysim3d marked this pull request as ready for review February 24, 2025 19:07
@andysim3d andysim3d force-pushed the andy/otlp-instrument branch from 560f47b to 45ae2bf Compare February 24, 2025 19:13
@andysim3d andysim3d merged commit 506d836 into feat/otlp-instrument Feb 24, 2025
10 checks passed
@andysim3d andysim3d deleted the andy/otlp-instrument branch February 24, 2025 21:53
andysim3d added a commit that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants