Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add otlp tracing #1030

Merged
merged 4 commits into from
Feb 24, 2025
Merged

feat: add otlp tracing #1030

merged 4 commits into from
Feb 24, 2025

Conversation

alex-miao
Copy link
Collaborator

@alex-miao alex-miao commented Feb 20, 2025 •
edited
Loading

Proposed Changes

  • Add OTLP tracing layer to send spans
  • Add LOG_OTLP_GRPC_ENDPOINT environment variable
  • Instrument a basic span

@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 59.52%. Comparing base (e96738d) to head (d9efab2).
Report is 1 commits behind head on feat/otlp-instrument.

Files with missing lines Patch % Lines
bin/rundler/src/cli/tracing.rs 0.00% 24 Missing ⚠️
crates/rpc/src/eth/router.rs 0.00% 5 Missing ⚠️
crates/rpc/src/eth/server.rs 0.00% 1 Missing ⚠️
crates/rpc/src/rundler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
bin/rundler/src/cli/mod.rs 0.00% <ø> (ø)
crates/rpc/src/eth/server.rs 0.00% <0.00%> (ø)
crates/rpc/src/rundler.rs 0.00% <0.00%> (ø)
crates/rpc/src/eth/router.rs 30.68% <0.00%> (-0.84%) ⬇️
bin/rundler/src/cli/tracing.rs 0.00% <0.00%> (ø)
Flag Coverage Δ
unit-tests 59.52% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <0.00%> (ø)
builder 67.64% <ø> (ø)
dev ∅ <ø> (∅)
pool 68.13% <ø> (ø)
provider 19.47% <ø> (ø)
rpc 26.77% <0.00%> (-0.10%) ⬇️
sim 78.21% <ø> (ø)
tasks ∅ <ø> (∅)
types 66.80% <ø> (ø)
utils 32.43% <ø> (ø)

@alex-miao alex-miao marked this pull request as ready for review February 21, 2025 22:06
andysim3d
andysim3d reviewed Feb 21, 2025
View reviewed changes
bin/rundler/src/cli/tracing.rs
.with_tonic()
.with_endpoint(endpoint)
.with_timeout(Duration::from_secs(3))
.with_metadata(MetadataMap::new())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum I am thinking maybe we want add network in metadata ...?

@andysim3d andysim3d changed the base branch from main to feat/otlp-instrument February 24, 2025 19:08
@andysim3d andysim3d merged commit 5c91c60 into feat/otlp-instrument Feb 24, 2025
13 checks passed
@andysim3d andysim3d deleted the alex/otlp-tracing branch February 24, 2025 19:09
andysim3d added a commit that referenced this pull request Feb 24, 2025
@alex-miao @andysim3d
feat: add otlp tracing (#1030)
42faa5f 
Co-authored-by: Pengfei(Andy) Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysim3d andysim3d andysim3d approved these changes

@dancoombs dancoombs Awaiting requested review from dancoombs dancoombs is a code owner

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@0xfourzerofour 0xfourzerofour Awaiting requested review from 0xfourzerofour 0xfourzerofour is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-miao @andysim3d