This repository was archived by the owner on May 20, 2025. It is now read-only.
Refactor specs to use ApiKey component #259
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoyroud
changed the title
|
@elan-halpern @SahilAujla how do I confirm this still runs fine with Readme? |
|
@bmoyroud there's no easy way to verify this. you need to upload specs to the test project to verify they're still working fine |
SahilAujla
approved these changes
Oct 19, 2023
|
@bmoyroud seems like this branch has conflicts, can you please resolve them? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Each file reimplements the
apiKeypath parameter.This means editing the apiKey requires Ctrl + F rather than editing the file in one place.
Solution
We have an API key component - let's use it 🕺 .