Skip to content

Conversation

@Richard-Dang
Copy link
Contributor

@Richard-Dang Richard-Dang commented Oct 16, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the wallet-api.yaml schema by improving validation patterns, adding error messages, and refining object structures to ensure proper Ethereum address and UUID formats.

Detailed summary

  • Updated regex patterns for Ethereum addresses to ensure they start with 0x.
  • Added error messages for invalid Ethereum addresses and UUIDs.
  • Defined required fields such as signerAddress, accountType, and accountAddress.
  • Enhanced descriptions for various properties to clarify usage.
  • Introduced new required fields in several objects, including factoryType and factoryAddress.
  • Structured signatureRequest and feePayment objects with clearer requirements and descriptions.
  • Improved multi-owner and single-owner account type definitions with error handling.
  • Consolidated and clarified the purpose of paymaster and erc20 settings.

The following files were skipped due to too many changes: docs/specs/openrpc/wallet-api/wallet-api.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@vercel
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
aa-sdk-ui-demo Ready Ready Preview Comment Oct 21, 2025 7:17pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 16, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Oct 21, 2025, 7:10 PM

@github-actions github-actions bot temporarily deployed to docs-preview October 16, 2025 16:34 Inactive
@Richard-Dang Richard-Dang enabled auto-merge (squash) October 16, 2025 16:56
@github-actions github-actions bot temporarily deployed to docs-preview October 21, 2025 18:01 Inactive
@github-actions github-actions bot temporarily deployed to docs-preview October 21, 2025 19:08 Inactive
auto-merge was automatically disabled November 6, 2025 21:07

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant