Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add link to explorer from smart account address #1367

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

jakehobbs
Copy link
Member

@jakehobbs jakehobbs commented Feb 15, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the functionality and structure of various components in the UI demo, particularly around link handling and wallet configuration, while introducing the use of forwardRef for ExternalLink.

Detailed summary

  • Refactored ExternalLink to use forwardRef.
  • Added support for multiple chains in alchemyConfig.
  • Integrated useChain hook in Configuration for dynamic chain setting.
  • Replaced UserAddressLink with UserAddressTooltip for improved address handling.
  • Added conditional rendering in UserAddressTooltip for link functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 11:18pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 11:18pm

Copy link

graphite-app bot commented Feb 15, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Collaborator

@adamegyed adamegyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We should wait on merging this until the non-7702 session key flow is brought over to arbitrum sepolia.

question: does the usage of setChain here depend on the fix from #1356 ? If so, it might be worth pushing a new aa-sdk release to include that change.

children,
...rest
}: LinkProps & { className?: string; children: React.ReactNode }) => {
const ExternalLink = forwardRef<
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another noob question: what does forwardRef do for us here? Is this something specific to nextjs / ssr?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

radix tooltip needs to be able to forward the ref to whatever we have as the tooltip trigger, so that they can use it for whatever they want to do w/ it.

@jakehobbs jakehobbs merged commit b436dba into main Feb 18, 2025
7 checks passed
@jakehobbs jakehobbs deleted the jake/add-explorer-wallet-link branch February 18, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants