-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add link to explorer from smart account address #1367
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We should wait on merging this until the non-7702 session key flow is brought over to arbitrum sepolia.
question: does the usage of setChain
here depend on the fix from #1356 ? If so, it might be worth pushing a new aa-sdk release to include that change.
children, | ||
...rest | ||
}: LinkProps & { className?: string; children: React.ReactNode }) => { | ||
const ExternalLink = forwardRef< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another noob question: what does forwardRef
do for us here? Is this something specific to nextjs / ssr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
radix tooltip needs to be able to forward the ref to whatever we have as the tooltip trigger, so that they can use it for whatever they want to do w/ it.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on enhancing the functionality and structure of various components in the UI demo, particularly around link handling and wallet configuration, while introducing the use of
forwardRef
forExternalLink
.Detailed summary
ExternalLink
to useforwardRef
.alchemyConfig
.useChain
hook inConfiguration
for dynamic chain setting.UserAddressLink
withUserAddressTooltip
for improved address handling.UserAddressTooltip
for link functionality.