chore: move optional mode into account params #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howydev
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson,
linnall,
adamegyed,
Zer0dot,
jaypaik,
Blu-J,
noam-alchemy,
jakehobbs and
archit2407
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamegyed
approved these changes
Feb 10, 2025
adamegyed
added a commit
that referenced
this pull request
Feb 10, 2025
…-kit/smart-contracts (#1287) * feat: sma 7702 * feat: adds 7702 support to alchemy signer (#1269) * feat: adds initial impl of signAuthorization * docs: adds signAuthorization documentation * fix: rename var * feat: 7702 progress * feat: update viem and debug 7702 auth * feat: add deterministically deployed demo nft * fix: don't re-sign delegations * feat: update 7702 middleware to higher order function * chore: merge fixes * fix: remove unnecessary console log * fix: correctly await client actions in infra test * fix: correctly encode yParity in zero case * feat: correctly set validation entity in nonce and separate encode actions * feat: consolidate MAv2Base * feat: add unified ma v2 client (#1309) * feat: add unified ma v2 client * chore: update docs * chore: make account source unique * feat: add ma v2 account to useSmartAccountClient hook (#1314) * feat: add unified ma v2 client * chore: make account source unique * feat: add ma v2 account to use smart contract client hook * chore: remove different type names * chore: rename mav2 to ModularAccountV2 * fix: review fix, add common type * fix: typo * fix: remove await * fix: narrow the type instead of doing non null assertion * chore: rebaseme * fix: client type and middleware inclusion * docs: update docs with twoslash * feat: update to new json format for auth * feat: add defaults for useSmartAccountClient to ma v2 (#1328) * fix: fix MAv2 React Hook client creation for 7702 (#1329) * fix: rename MAv2 type to mode, add 7702 middleware for react hook * fix: don't switch MintCard to MAv2 yet * fix: reconnect 7702 account after page refresh * chore: remove comment * docs: regen docs * fix: fix docs * fix: remove unnecessary optional chaining * feat: update eip 7702 auth format * fix: make mode optional in useSmartAccountClient (#1335) * chore: move optional mode into account params (#1339) * chore: move optional mode into account params * chore: removed unused var * fix: make type really optional, add defaults for return type (#1338) * refactor: assert exhaustive account type handling in getSmartAccountClient --------- Co-authored-by: Linna <[email protected]> Co-authored-by: howy <[email protected]> Co-authored-by: jakehobbs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR primarily focuses on making the
modeproperty optional in thecreateModularAccountV2function and related configurations, which enhances flexibility in account creation.Detailed summary
mode: "default"tomode?: "default"inmodularAccountV2.ts.undefinedformode.maV2Paramscreation by removing the defaultmodeassignment.modeproperty.