-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: syntax error in demo GA script & hydration warning #1333
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
4fc5f7e
to
9460603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
* fix: quote GA ID & fix UserAvatar hydration warning * chore: remove "use client"
* fix: quote GA ID & fix UserAvatar hydration warning * chore: remove "use client"
These issues have been displaying in the console on the demo app:
The first is due to the GA ID not being quoted.
The second is due to the UserAvatar colors being randomly shuffled, so the colors to not match between the server and client render.
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR focuses on improving the
UserAvatar
component by changing the color shuffling logic to ensure consistent rendering between server and client. It also updates the Google Analytics configuration.Detailed summary
gtag
configuration syntax inGoogleAnalytics.tsx
.shuffleColors
withshuffleColorsDeterministically
inUserAvatar.tsx
for consistent color ordering.useMemo
dependency to includeaddress
inUserAvatar.tsx
.