feat: eip-7702 support in aa-sdk/core, and sma7702 support in account-kit/smart-contracts #1287
Conversation
adamegyed
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson,
linnall,
howydev,
Zer0dot,
jaypaik,
Blu-J,
noam-alchemy and
jakehobbs
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
adamegyed
changed the title
adamegyed
force-pushed
the
adam/7702-core
branch
from
6797694 to
ed436d8
Compare
There was a problem hiding this comment.
this is looking good!
One thing missing is some client.test at a minimum (though would be great if we could extend it to installValidation.ts and have unit tests for installValidation.test.ts)
OOS for this PR is the naming I think, but calling it out here as @howydev and @linnall look at consolidating to the Prism naming as just looking at this PR it's clear that it'll be much better devex externally to have both a Prism account factory and Prism client factory for release
|
|
||
| export type MAV2Account< | ||
| TSigner extends SmartAccountSigner = SmartAccountSigner | ||
| > = SmartContractAccountWithSigner<"MAV2Account", TSigner, "0.7.0"> & { |
There was a problem hiding this comment.
I think this base type should probably be generic on source as well since source should be unique per instance (ie. the first generic parameter in SmartContractAccountWithSigner)
| signer: TSigner; | ||
| entryPoint?: EntryPointDef<"0.7.0", Chain>; | ||
| signerEntity?: SignerEntity; |
There was a problem hiding this comment.
oh yea I remember seeing this during hackathon and thinking it odd. Why can't we merge signer and signerEntity?
account-kit/smart-contracts/src/ma-v2/account/semiModularAccount7702.ts
Outdated
Show resolved
Hide resolved
site/pages/reference/account-kit/infra/functions/alchemyGasManagerMiddleware.mdx
Outdated
Show resolved
Hide resolved
adamegyed
force-pushed
the
adam/7702-core
branch
from
c0d52b7 to
847ab00
Compare
adamegyed
force-pushed
the
adam/7702-core
branch
from
bfc87e7 to
b3acd54
Compare
* chore: move optional mode into account params * chore: removed unused var
| const is7702 = | ||
| params.accountParams && | ||
| "mode" in params.accountParams && | ||
| params.accountParams.mode === "7702"; |
There was a problem hiding this comment.
nit simplification:
const is7702 = params?.accountParams?.mode === "7702";
There was a problem hiding this comment.
actually, if its just used in a single place, you can probably do it below directly
There was a problem hiding this comment.
makes sense to me to simplify, cc @jakehobbs since this was originally from https://github.com/alchemyplatform/aa-sdk/pull/1329/files#diff-454ebcaf71636677b50d6564ee14fec20267d25b134f5487855ce1e7bc3f8705R222
There was a problem hiding this comment.
Hmm, it seems like the branching destructuring at the top of this file is breaking the type relationship between account.source and params.accountParams, even though we can obviously see that there should be a relationship.
For now, I'll leave it as is, and make note of avoiding this type of destructuring to preserve type checking.
| @@ -277,9 +221,22 @@ export async function createSMAV2Account( | |||
| : callData; | |||
| }; | |||
|
|
|||
| const baseAccount = await toSmartContractAccount({ | |||
There was a problem hiding this comment.
hmm, instead of modifying toSmartContractAccount, another option would be to override getNonce and getImplementationAddress when unrolling below right?
this would be a bigger refactor and there's no issue with the current impl, so think we can keep the existing one for speed
There was a problem hiding this comment.
I think @moldy530 considered the unrolling-override as an anti-pattern, from these discussions:
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR primarily updates the
viempackage version across multiplepackage.jsonfiles and introduces theModularAccountV2functionality, including new methods and types for account creation and management.Detailed summary
viemversion from^2.20.0to^2.22.6in multiplepackage.jsonfiles.ModularAccountV2support in several components.ModularAccountV2.ModularAccountV2.ModularAccountV2in the React components.