Skip to content

Add error state to login and register forms #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daryllxd
Copy link

@daryllxd daryllxd commented Mar 29, 2025

Hello, was just trying the repo out and when I forgot to start the API server, there was no clear error message. IMO app should show a message to if the users weren't able to log in or register, especially for newbies in React trying to figure a good app structure to base off of

  • Add a simple error message for potential server errors for just the first two screens, login and register. (It could be more declarative, I just returned the actual error message for now).
  • Needed to add className prop to Error to not make the error message too cramped.
Login Register
image image

Caveat

  • Didn't add for the other forms yet and didn't add the tests yet

Copy link

netlify bot commented Mar 29, 2025

Deploy Preview for bulletproof-react-app canceled.

Name Link
🔨 Latest commit c6a841e
🔍 Latest deploy log https://app.netlify.com/sites/bulletproof-react-app/deploys/67e767816117590008f99830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant