-
Notifications
You must be signed in to change notification settings - Fork 4
Added optional flag showToast. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
close #2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aryany9,
Thanks for the PR! Your code works well, but I suggest an improvement for handling the showToast flag.
If showToast is set to false, it would be better to avoid creating the broadcast receivers and not passing them to the sendTextMessage method.
This way, we can reduce unnecessary overhead.
Implemented Event Channel to receive SMS status from the broadcast receivers.
|
Hi @akshaydoshi2 , I reviewed your suggestion and tried to implement the same however, As per the roadmap we have to implement the event channel as well to receive the SMS status from the broadcast receivers which makes it necessary to be there irrespective of the showToast flag. My latest commit on the branch implemented the event channel to receive the sms status. Hope so this will work as expected. |
|
Hey @aryany9, |
fixing Intent Redirection vulnerability
No description provided.