[14.0] [FIX] sale_configurator_base: Check editable tree state #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent loss of modifications in sale order lines in case of editable="" tree. This can happen if some module like product_contract changes this attribute. In this case the field should not be readonly otherwise the UI will accept changes in the form but won't effectively save them.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 14.0 #59 +/- ##
==========================================
- Coverage 82.44% 82.24% -0.20%
==========================================
Files 47 47
Lines 826 828 +2
Branches 154 154
==========================================
Hits 681 681
- Misses 127 129 +2
Partials 18 18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent loss of modifications in sale order lines in case of editable="" tree.
This can happen if some module like product_contract changes this attribute.
In this case the field should not be readonly otherwise the UI will accept changes in the form but won't effectively save them.