forked from hammerlab/pileup.js
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix variant track labels #15
Open
Georgehe4
wants to merge
146
commits into
akmorrow13:master
Choose a base branch
from
Georgehe4:label_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and Genotype.js constructors to take in objects instead
…atureDataSource-test.js file
…th RemoteRequest file
…and Genotype.js constructors to take in objects instead
fixed no data error for alignments and max rows for PileupTrack
…uest areas already in cache.
Variant fixes
# Conflicts: # src/main/sources/GA4GHDataSource.js
Update Feature Transparency Based on Score
Can one of the admins verify this patch? |
This looks awesome! Does this apply to all the tracks or just variants? Is there anyway we could do text overflow to be ellipsis so the user knows there is more extension? |
Updated! |
These changes should go in the hammerlab pileup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before

After [no hover]

After [hover]

Modify overflow and positioning so variant labels show up.