Update coverage tracking #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and Genotype.js constructors to take in objects instead
…atureDataSource-test.js file
…th RemoteRequest file
…and Genotype.js constructors to take in objects instead
fixed no data error for alignments and max rows for PileupTrack
…uest areas already in cache.
Variant fixes
# Conflicts: # src/main/sources/GA4GHDataSource.js
Update Feature Transparency Based on Score
|
Can one of the admins verify this patch? |
akmorrow13
reviewed
Apr 30, 2017
src/main/viz/PileupCoverageTrack.js
Outdated
| localYScaleForRef(ref: string): (y: number) => number { | ||
| var maxCoverage = this.cache.maxCoverageForRef(ref); | ||
|
|
||
| var padding = 20; // TODO: move into style |
There was a problem hiding this comment.
This is an artifact of the original yScaleForRef.
akmorrow13
reviewed
Apr 30, 2017
src/main/viz/PileupCoverageTrack.js
Outdated
| @@ -65,11 +65,21 @@ class CoverageTiledCanvas extends TiledCanvas { | |||
| .nice(); | |||
| } | |||
|
|
|||
| localYScaleForRef(ref: string): (y: number) => number { | |||
There was a problem hiding this comment.
The padding created in the original yScaleForRef seems to cause the y-coordinate of the DataCanvasRenderingContext2D in the render function to be shifted off by 10 degrees. The original yScaleForRef is still used to generate the tick marks, so I create another one for rendering coverage tiles that shouldn't be used outside of context of coverage tiles.
There was a problem hiding this comment.
I dont love the idea of having YScaleForRef and localYScaleForRef. We should probably just have 1 function.
Georgehe4
force-pushed
the
coverage_track
branch
2 times, most recently
from
d845a3a to
95fa18e
Compare
Georgehe4
force-pushed
the
coverage_track
branch
from
95fa18e to
cedf37a
Compare
|
Updated |
|
These changes should go in the hammerlab pileup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Modify coverage track to show lower coverage regions.