Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Auto PR akka-samples #271

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

build: Auto PR akka-samples #271

wants to merge 5 commits into from

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Mar 3, 2025

with:
repository: akka-samples/shopping-cart-quickstart
path: akka-samples-repo-shopping-cart-quickstart
token: ${{ secrets.AKKA_SDK_RW_ACCESS_TOKEN }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to create this

run: |
cd akka-samples-repo-shopping-cart-quickstart
git config user.name "github-actions[bot]"
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is the one we want to use? it was already used in this repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also surprised by this in a PR review, for the record It's a global github actions bot user id (https://api.github.com/users/github-actions%5Bbot%5D)

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@github-actions github-actions bot added the documentation documentation related label Mar 3, 2025
@patriknw
Copy link
Member Author

patriknw commented Mar 3, 2025

marking as draft until we have credentials, and have tried it for real

@patriknw patriknw marked this pull request as draft March 3, 2025 14:44
@patriknw patriknw force-pushed the wip-samples-patriknw branch from 7f2d887 to 2fe1bdc Compare March 4, 2025 08:11
@patriknw
Copy link
Member Author

patriknw commented Mar 4, 2025

I have addd two more things

  • include Run_locally.xml 42c136b
  • use bundled samples, to remove doc tags 2fe1bdc

.idea
!.idea/
.idea/*
!.idea/runConfigurations/Run_locally.xml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks crazy, but seems to work. found it here https://github.com/daggerok/gitignore-idea-runConfigurations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants