Skip to content

Replace the download function from AssetMediaFileApiInterface #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace the download function from AssetMediaFileApiInterface #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Api/AssetManager/AssetMediaFileApi.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public function __construct(ResourceClientInterface $resourceClient, FileSystemI
/**
* {@inheritdoc}
*/
public function download($code): ResponseInterface
public function download(string $code): ResponseInterface
{
return $this->resourceClient->getStreamedResource(static::MEDIA_FILE_DOWNLOAD_URI, [$code]);
}
Expand Down
14 changes: 2 additions & 12 deletions src/Api/AssetManager/AssetMediaFileApiInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,12 @@

namespace Akeneo\Pim\ApiClient\Api\AssetManager;

use Akeneo\Pim\ApiClient\Api\Operation\DownloadableResourceInterface;
use Akeneo\Pim\ApiClient\Exception\HttpException;
use Akeneo\Pim\ApiClient\Exception\RuntimeException;
use Psr\Http\Message\ResponseInterface;

interface AssetMediaFileApiInterface
interface AssetMediaFileApiInterface extends DownloadableResourceInterface
{
/**
* Downloads an asset media file by its code
*
* @param string $code Code of the media file
*
* @throws HttpException If the request failed.
*
* @return ResponseInterface
*/
public function download($code): ResponseInterface;

/**
* Creates a new asset media file.
Expand Down