New system #9
Open
New system #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
reviewed
Oct 16, 2025
| import Foundation | ||
|
|
||
| // FIXME: Fix with proper serialisation | ||
| public struct TemporarySerialization: Sendable { |
There was a problem hiding this comment.
this should be able to be pretty simple in the end; originally we were ready to mix serialization mechanisms but that isn't a thing anymore really with SerializationRequirement
Owner
Author
There was a problem hiding this comment.
Yup, old Serialization has a lot of stuff which we don't need anymore, I guess. I want to return to this later, that's why put FIXME. But guess will do it in the end and check even something needed, as simple json encoder/decoder will work for now.
ktoso
reviewed
Oct 16, 2025
| } | ||
|
|
||
| // TODO: Needed for actorid now, refactor or remove when adding serialization | ||
| extension ClusterSystem.ActorID: Codable {} |
Owner
Author
There was a problem hiding this comment.
Yeah, put this comment at the very beginning of refactoring, should be just codable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking code changes and tests