Skip to content

feat: serverLauncher to successfully start the Node.js server #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 31 commits into
base: dev-node-process
Choose a base branch
from

Conversation

stone-lyl
Copy link
Collaborator

@stone-lyl stone-lyl commented Apr 28, 2025

  • Compare the running structure of ds-ext before and after adding the node process
Before After
image image
  • It has successfully handled reading and writing of a large CSV file with 600,000 rows, and it remains stable even when adding node diagrams like Map.
nodejs-process.mp4
  • I have tested both playground and playground-node, and they run smoothly.
  • How to start the new socket server, please click here

todo:

  1. Customize the server startup command.
  2. Currently, all diagrams' runtime data are stored in a single execution.db or execution.json file, with only the latest run record kept per diagram.
  • The handling of DuckDB remains the same as before.
  • I'm unsure about the JSON processing ?

Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
data-story-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 2:58am

// try resolve '@duckdb/node-api' with esm import
// if fails, execute 'npm install @duckdb/node-api@^1.2.2-alpha.18 --save'

function hasDryRunFlag() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a security mechanism that allows users to preview the actions to be performed without actually executing them.

@@ -102,6 +122,20 @@
"name": "Node Details"
}
]
},
"configuration": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used to define configurable options for extensions, for example:

{
  "datastory.additionalDsServerCliArgs": [
    "--max-old-space-size=4096",
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant