Skip to content

Reformat & Refactored #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Reformat & Refactored #4

wants to merge 4 commits into from

Conversation

sh6210
Copy link

@sh6210 sh6210 commented Oct 28, 2021

Refactored, hope this will increase readability.

ajaxray
ajaxray requested changes Oct 30, 2021
View reviewed changes
Copy link
Owner

@ajaxray ajaxray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good findings. Suggested a few changes regarding PSR coding style.

@sh6210
Resolved feedback
7b36293 
Fixed applying PSR rules
@sh6210
Copy link
Author

sh6210 commented Oct 30, 2021

Resolved.

@sh6210 sh6210 requested a review from ajaxray November 13, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaxray ajaxray Awaiting requested review from ajaxray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh6210 @ajaxray