Skip to content

Diff view papercuts #5815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Diff view papercuts #5815

wants to merge 5 commits into from

Conversation

nightwing
Copy link
Member

Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 87.01299% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.47%. Comparing base (5209bd6) to head (2b3220b).

Files with missing lines Patch % Lines
src/ext/diff/inline_diff_view.js 72.72% 6 Missing ⚠️
src/ext/diff/base_diff_view.js 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5815      +/-   ##
==========================================
+ Coverage   87.45%   87.47%   +0.02%     
==========================================
  Files         611      613       +2     
  Lines       45669    45742      +73     
  Branches     7498     7506       +8     
==========================================
+ Hits        39938    40014      +76     
+ Misses       5731     5728       -3     
Flag Coverage Δ
unittests 87.47% <87.01%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marinsokol5
Copy link
Contributor

There seems to be a bug when the active line is showed multiple times:
Screenshot 2025-05-23 at 10 35 39

@nightwing nightwing force-pushed the diff-view-papercuts branch 2 times, most recently from f5e7c5a to 279307f Compare May 26, 2025 01:01
@nightwing nightwing force-pushed the diff-view-papercuts branch from 279307f to 6515995 Compare May 30, 2025 05:55
@nightwing nightwing force-pushed the diff-view-papercuts branch from 08c2a49 to 2b3220b Compare May 30, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants