Skip to content

Feat: Add scroll diff decorators #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 4, 2025
Merged

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented May 13, 2025

Issue #, if available:

Description of changes:

  • Improve placement of error decorators (now they would better reflect folds/wraps and lineWidgets)
  • Add diff decorators for both inline/split diff views
    image
    image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@mkslanc mkslanc marked this pull request as draft May 13, 2025 14:26
@mkslanc mkslanc marked this pull request as ready for review May 13, 2025 14:30
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 96.95652% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.67%. Comparing base (35e1be5) to head (04f0b50).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ext/diff/base_diff_view.js 94.54% 3 Missing ⚠️
src/layer/decorators.js 95.91% 2 Missing ⚠️
src/ext/diff/diff_test.js 98.11% 1 Missing ⚠️
src/ext/diff/scroll_diff_decorator.js 98.52% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5807      +/-   ##
==========================================
+ Coverage   87.61%   87.67%   +0.05%     
==========================================
  Files         613      614       +1     
  Lines       45774    45940     +166     
  Branches     7507     7529      +22     
==========================================
+ Hits        40106    40276     +170     
+ Misses       5668     5664       -4     
Flag Coverage Δ
unittests 87.67% <96.95%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akoreman
Copy link
Contributor

akoreman commented Jun 3, 2025

The decorator for diffs looks really cool 🚀 @mkslanc could you please resolve the merge conflicts for this PR

mkslanc added 2 commits June 3, 2025 20:38
# Conflicts:
#	src/ext/diff/base_diff_view.js
#	src/ext/diff/diff_test.js
@mkslanc
Copy link
Contributor Author

mkslanc commented Jun 4, 2025

The decorator for diffs looks really cool 🚀 @mkslanc could you please resolve the merge conflicts for this PR

This should make it.

@akoreman akoreman merged commit b45e94c into ajaxorg:master Jun 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants