Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor fixes #4

wants to merge 1 commit into from

Conversation

tanvach
Copy link

@tanvach tanvach commented May 20, 2018

Fixes two small issues I came across before I could get the script to run:

  • Pytorch now treats true scalar (dimension [1]) differently to a singleton (dimension [1x1]). This broke the loss computation at loss_GAN_A2B = criterion_GAN(pred_fake, target_real) step. Fixed by making target_real and target_fake tensors.
  • Method to start Visdom is now updated

@aitorzip

@Pandinosaurus
Copy link

Thank you @tanvach ! Your patch also does the job on my setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants