[source-xero] ParseDates.convert_dates - fix for datetime truncation #51009
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@absorbb is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
octavia-squidington-iii
added
area/connectors
absorbb
had a problem deploying
to
community-ci-auto
GitHub Actions
Failure
|
Hello @absorbb can you create a branch in your fork and submit a new contribution. Pushing the master branch directly breaks Airbyte CI pipeline to validate your changes. |
absorbb
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
|
@marcosmarxm Done: #51034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51007
What
The condition
if isinstance(parsed_value, date)is always true even for datetime instances ( Reproducible Example )So it always replaces time part of all datetime instances with 00:00:00
How
Replaced isinstance with the exact type checking
User Impact
UpdatedDateUTCfield of all entities will finally have time partCan this PR be safely reverted and rolled back?