-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add empty_streams filtering to standard test suites #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add empty_streams filtering to standard test suites #641
Conversation
- Add EmptyStreamConfig model and empty_streams field to ConnectorTestScenario - Extend get_scenarios() to include basic_read category - Implement catalog filtering in test_basic_read and test_docker_image_build_and_read methods - Exclude streams declared as empty_streams from test execution to prevent failures in sandbox environments Co-Authored-By: AJ Steers <[email protected]>
Original prompt from AJ Steers:
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
PyTest Results (Full)3 688 tests 3 677 ✅ 17m 54s ⏱️ Results for commit 86fd9a6. ♻️ This comment has been updated with latest results. |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1751411517-filter-empty-streams-from-tests#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1751411517-filter-empty-streams-from-tests Helpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
/autofix
|
Add empty_streams filtering to standard test suites
Summary
This PR implements filtering functionality for the Python CDK standard test suites to exclude streams declared as
empty_streams
in acceptance-test-config.yml files. This prevents premium/unsupported streams from causing test failures in sandbox environments where connectors may not have access to all stream types.Key Changes:
EmptyStreamConfig
model andempty_streams
field toConnectorTestScenario
get_scenarios()
to include "basic_read" category for proper test parametrizationtest_basic_read()
andtest_docker_image_build_and_read()
methodsempty_streams
configuration are now excluded from configured catalogs before test executionReview & Testing Checklist for Human
empty_streams
configuration in acceptance-test-config.ymlempty_streams
config still work normally (no regressions)EmptyStreamConfig
model matches actual structure used in acceptance-test-config.yml files (name + bypass_reason fields)Recommended Test Plan:
Diagram
Notes
read_from_streams
filtering)EmptyStreamConfig
model structure matches the format seen in source-amazon-ads acceptance-test-config.yml