-
Notifications
You must be signed in to change notification settings - Fork 24
feat: adds new ValidateInLineCondition
component
#580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pnilan
wants to merge
10
commits into
main
Choose a base branch
from
pnilan/feat/in-line-validation-strategy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fbde330
adds new `ValidateInLineCondition` component
pnilan 8694769
remove dagger-io
pnilan 33c629e
add dagger-io and ignore in DEP002
pnilan 193db50
fix tests
pnilan fd8dae2
chore: format
pnilan 5ba3320
Update airbyte_cdk/sources/declarative/declarative_component_schema.yaml
pnilan c10c497
add creation method to init mappings
pnilan 57ab737
Merge branch 'main' into pnilan/feat/in-line-validation-strategy
pnilan abaa0b0
fix poetry lock
pnilan cd6655b
fix predicate validator
pnilan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
airbyte_cdk/sources/declarative/validators/validate_in_line_condition.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# | ||
# Copyright (c) 2025 Airbyte, Inc., all rights reserved. | ||
# | ||
|
||
from dataclasses import dataclass | ||
from typing import Any | ||
|
||
from jinja2.exceptions import TemplateError | ||
|
||
from airbyte_cdk.sources.declarative.interpolation.interpolated_boolean import InterpolatedBoolean | ||
from airbyte_cdk.sources.declarative.validators.validation_strategy import ValidationStrategy | ||
from airbyte_cdk.sources.types import Config | ||
|
||
|
||
@dataclass | ||
class ValidateInLineCondition(ValidationStrategy): | ||
""" | ||
Validation strategy that evaluates the argument as an InterpolatedBoolean. | ||
""" | ||
|
||
config: Config | ||
|
||
def validate(self, value: Any) -> None: | ||
""" | ||
Validates the argument as an InterpolatedBoolean. | ||
|
||
:param value: The value to validate | ||
:raises ValueError: If the condition is not a string or evaluates to False | ||
""" | ||
|
||
if isinstance(value, str): | ||
interpolated_condition = InterpolatedBoolean(value, parameters={}) | ||
try: | ||
result = interpolated_condition.eval(self.config) | ||
except TemplateError as e: | ||
raise ValueError(f"Invalid jinja expression: {value}.") from e | ||
except Exception as e: | ||
raise ValueError(f"Unexpected error evaluating condition: {value}.") from e | ||
|
||
if not result: | ||
raise ValueError(f"Condition evaluated to False: {value}.") | ||
else: | ||
raise ValueError(f"Invalid condition argument: {value}. Should be a string.") |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.