This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Add an updated example that works with Ruby 2.6.8 #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csharplus
force-pushed
the
csharplus_update_ruby_example
branch
from
667f5be to
41d4806
Compare
|
@ljharb could you please review this PR? |
|
@lencioni could you please review and stamp this PR, thanks. |
|
It seems reasonable, but i haven’t had time to check out and run the example app. it hasn’t even been 2 weeks; what’s the rush? |
Sure, it is not urgent. Please review it at your earliest convenience, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example 'simple' does not work with the latest version Ruby 2.6.8.