fix(AIP-160): clarify unset field in traversal behavior #1469
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
reviewed
Jan 13, 2025
| @@ -138,6 +138,12 @@ the service **should** return an error with `INVALID_ARGUMENT`. A service | |||
| **may** permit traversal to undefined keys on maps and structs, and **should** | |||
| document how it behaves in this situation. | |||
|
|
|||
| When evaluating an expression involving a traversal, if any non-primitive field | |||
There was a problem hiding this comment.
What about if the comparison is a "not equal" one?
There was a problem hiding this comment.
Regardless of the comparison in that case, it is skipped, at least that is my understanding of the feedback I got from maintainers. Unset == no value comparison at all.
I believe this is because of the ambiguity of the intent in such a filter - do they want to filter for entries that have a set and a.b != "foo" OR do they want to filter for entries that either do not have a set or a set and a.b != "foo".
This is where a Has operator would come into play e.g. "has: a AND a.b != "foo""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the expected behavior when a non-primitive field in a traversal operator's chain of fields is not set, it should be skipped i.e. not matched. This has been the expected behavior since inception, but was undocumented.
Internal bug http://b/388065878