Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AliasBookRevision request parameter in AIP 162. #1409

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Update AliasBookRevision request parameter in AIP 162. #1409

merged 2 commits into from
Dec 11, 2024

Conversation

itsjorgebar
Copy link
Contributor

Replaces the deprecated keyword Tag with Alias, as proposed in e487231#r126474493. This coincides with AIP 162's Tagging to Aliases section:

Previously, a concept of tag existed. This concept was redundant with that of an alias, and the terms were consolidated to reduce complexity in the AIPs.

@itsjorgebar
Update AliasBookRevision request parameter in AIP 162.
c03e788 
Replaces the deprecated keyword `Tag` with  `Alias`.
@itsjorgebar itsjorgebar requested a review from a team as a code owner August 21, 2024 23:48
@itsjorgebar itsjorgebar requested a review from itsStrobe August 21, 2024 23:48
noahdietz
noahdietz approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @itsjorgebar ! Sorry it went unseen for so long.

@noahdietz noahdietz merged commit 46794fe into aip-dev:master Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

@itsStrobe itsStrobe Awaiting requested review from itsStrobe itsStrobe is a code owner automatically assigned from aip-dev/google

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsjorgebar @noahdietz