Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AIP-193): remove references to non-existent field on google.rpc.Status #1278

Closed
wants to merge 0 commits into from
Closed

fix(AIP-193): remove references to non-existent field on google.rpc.Status #1278

wants to merge 0 commits into from

Conversation

andrei-scripniciuc
Copy link
Contributor

@andrei-scripniciuc andrei-scripniciuc requested a review from a team as a code owner November 29, 2023 19:19
@noahdietz
Copy link
Collaborator

I agree with this change, and I think it is worth doing, but let me offer an explanation. The "old"/"other" API Errors documentation includes such a field:
image

@noahdietz noahdietz changed the title remove references to non-existent field on google.rpc.Status fix(AIP-193): remove references to non-existent field on google.rpc.Status Nov 30, 2023
@noahdietz
Copy link
Collaborator

The JSON blob in this AIP is based on that, because that's what our HTTP transcoded error response bodies look like.

It is not a direct serialization of google.rpc.Status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

@hrasadi hrasadi Awaiting requested review from hrasadi hrasadi was automatically assigned from aip-dev/google

@alin04 alin04 Awaiting requested review from alin04 alin04 was automatically assigned from aip-dev/google

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrei-scripniciuc @noahdietz