Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting of a list in AIP 129. #1271

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Conversation

TheApX
Copy link
Contributor

@TheApX TheApX commented Nov 16, 2023

Add an empty line between the list title and actual list, so that it is formatted properly. A trailing whitespace is also removed by VS Code auto-formatting.

Add an empty line between the list title and actual list, so that it is formatted properly.
@TheApX TheApX requested a review from a team as a code owner November 16, 2023 00:56
@TheApX TheApX requested review from hrasadi and alin04 November 16, 2023 00:56
Copy link

google-cla bot commented Nov 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@TheApX
Copy link
Contributor Author

TheApX commented Nov 22, 2023

Just out of curiosity (and as a gentle ping) - how long does it usually take to get simple PRs like this one reviewed? Do I need to do anything other than signing the CLA? Which I already did. AIP 1 describes review process for new AIPs, but nothing about minor fixes like this one.

@noahdietz
Copy link
Collaborator

Just out of curiosity (and as a gentle ping) - how long does it usually take to get simple PRs like this one reviewed? Do I need to do anything other than signing the CLA?

Apparently it takes over a year :) Sorry about that, and thanks for taking the time to even open this in the first place.

AIP 1 describes review process for new AIPs, but nothing about minor fixes like this one.

Indeed, that still holds true for bigger changes, but I have since relaxed the GitHub review minimum back to 1 to facilitate small changes like this.

@noahdietz noahdietz merged commit 7cf198a into aip-dev:master Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants