Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typos with spellchecker #1248

Merged
merged 6 commits into from
Nov 22, 2023
Merged

chore: fix typos with spellchecker #1248

merged 6 commits into from
Nov 22, 2023

Conversation

jonnekleijer
Copy link
Contributor

  • Run npx cspell aip/**/*.md
  • Fix some mistakes

@jonnekleijer jonnekleijer requested review from a team as code owners October 18, 2023 18:24
@jonnekleijer
Copy link
Contributor Author

@noahdietz
I noticed a typo and decided to run a spell checker on the files. I found a few, which are fixed in this PR.

noahdietz
noahdietz approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, thank you.

@noahdietz noahdietz requested review from westarle and removed request for jskeet November 17, 2023 16:13
@noahdietz
Copy link
Collaborator

@westarle could you stamp this as an auth AIP owner? Just typo fixes.

@noahdietz noahdietz changed the title Run spell check chore: fix typos with spellchecker Nov 17, 2023
@arithmetic1728 arithmetic1728 merged commit 780e930 into aip-dev:master Nov 22, 2023
@jonnekleijer
Copy link
Contributor Author

@westarle
Thanks for your review. I could add a spell check build step to prevent typo's in the aip documentation.

@noahdietz noahdietz mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

@westarle westarle Awaiting requested review from westarle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonnekleijer @noahdietz @arithmetic1728