Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'partitioned' parameter to set_cookie method. #10371

Merged
merged 7 commits into from
Feb 3, 2025

Conversation

jpjacobpadilla
Copy link
Contributor

@jpjacobpadilla jpjacobpadilla commented Feb 3, 2025

What do these changes do?

Fixes #9870

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES/ folder

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 3, 2025
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.75%. Comparing base (892a4fc) to head (de5c472).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_helpers.py 25.00% 6 Missing ⚠️
aiohttp/helpers.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10371      +/-   ##
==========================================
- Coverage   98.77%   98.75%   -0.03%     
==========================================
  Files         122      122              
  Lines       37038    37048      +10     
  Branches     2041     2042       +1     
==========================================
+ Hits        36585    36587       +2     
- Misses        314      321       +7     
- Partials      139      140       +1     
Flag Coverage Δ
CI-GHA 98.64% <20.00%> (-0.03%) ⬇️
OS-Linux 98.32% <20.00%> (-0.03%) ⬇️
OS-Windows 96.24% <20.00%> (-0.03%) ⬇️
OS-macOS 97.44% <20.00%> (-0.03%) ⬇️
Py-3.10.11 97.33% <20.00%> (-0.03%) ⬇️
Py-3.10.16 97.90% <20.00%> (-0.03%) ⬇️
Py-3.11.11 97.98% <20.00%> (-0.03%) ⬇️
Py-3.11.9 97.42% <20.00%> (-0.02%) ⬇️
Py-3.12.8 98.42% <20.00%> (-0.03%) ⬇️
Py-3.13.1 98.41% <20.00%> (-0.03%) ⬇️
Py-3.9.13 97.22% <20.00%> (-0.03%) ⬇️
Py-3.9.21 97.78% <20.00%> (-0.03%) ⬇️
Py-pypy7.3.16 97.37% <20.00%> (-0.03%) ⬇️
VM-macos 97.44% <20.00%> (-0.03%) ⬇️
VM-ubuntu 98.32% <20.00%> (-0.03%) ⬇️
VM-windows 96.24% <20.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #10371 will improve performances by 10.57%

Comparing jpjacobpadilla:master (de5c472) with master (892a4fc)

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_one_hundred_get_requests_with_512kib_chunked_payload[pyloop] 233.8 ms 211.4 ms +10.57%

@Dreamsorcerer Dreamsorcerer added the backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot label Feb 3, 2025
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) February 3, 2025 14:33
@Dreamsorcerer Dreamsorcerer merged commit f46ccff into aio-libs:master Feb 3, 2025
36 of 37 checks passed
Copy link
Contributor

patchback bot commented Feb 3, 2025

Backport to 3.12: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply f46ccff on top of patchback/backports/3.12/f46ccff6cd0d6043b8dc817f258b5aee8a5a4443/pr-10371

Backporting merged PR #10371 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.12/f46ccff6cd0d6043b8dc817f258b5aee8a5a4443/pr-10371 upstream/3.12
  4. Now, cherry-pick PR Added 'partitioned' parameter to set_cookie method. #10371 contents into that branch:
    $ git cherry-pick -x f46ccff6cd0d6043b8dc817f258b5aee8a5a4443
    If it'll yell at you with something like fatal: Commit f46ccff6cd0d6043b8dc817f258b5aee8a5a4443 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x f46ccff6cd0d6043b8dc817f258b5aee8a5a4443
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Added 'partitioned' parameter to set_cookie method. #10371 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.12/f46ccff6cd0d6043b8dc817f258b5aee8a5a4443/pr-10371
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@Dreamsorcerer
Copy link
Member

If you could follow the backport instructions, that'd be great.

@jpjacobpadilla
Copy link
Contributor Author

I should be able to do that! This is my first contribution to aiohttp so I'll have to read through those instructions tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for setting partitioned cookies
2 participants