Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the regexp-clone package with improved development tooling, better documentation, and additional test coverage. The changes modernize the package structure and add comprehensive TypeScript support.
- Adds TypeScript definitions, ESLint configuration, and Prettier formatting
- Expands test coverage to include error handling for non-RegExp inputs
- Updates package.json with modern exports, build scripts, and development dependencies
Reviewed Changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/index.js | Adds semicolons for consistency, corrects flag ordering, and adds new test cases for non-RegExp inputs |
| package.json | Adds modern package exports, TypeScript support, build scripts, and development dependencies |
| index.js | Adds JSDoc documentation, TypeScript type annotations, and exports additional utility functions |
| eslint.config.mts | New ESLint configuration file with modern flat config format |
| README.md | Updates documentation with badges, corrected flag ordering, and improved examples |
| .prettierrc | New Prettier configuration for code formatting |
| .npmrc | New npm configuration with lockfile and versioning settings |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| }); | ||
|
|
||
| describe('non-RegExps', () => { | ||
| it('should throwfor strings', () => { |
There was a problem hiding this comment.
There's a typo in the test description. 'throwfor' should be 'throw for'.
Suggested change
| it('should throwfor strings', () => { | |
| it('should throw for strings', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.