Skip to content

More#14

Merged
aheckmann merged 15 commits intomainfrom
more
Aug 13, 2025
Merged

More#14
aheckmann merged 15 commits intomainfrom
more

Conversation

@aheckmann
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings August 13, 2025 19:35
@aheckmann aheckmann enabled auto-merge August 13, 2025 19:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the regexp-clone package with improved development tooling, better documentation, and additional test coverage. The changes modernize the package structure and add comprehensive TypeScript support.

  • Adds TypeScript definitions, ESLint configuration, and Prettier formatting
  • Expands test coverage to include error handling for non-RegExp inputs
  • Updates package.json with modern exports, build scripts, and development dependencies

Reviewed Changes

Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/index.js Adds semicolons for consistency, corrects flag ordering, and adds new test cases for non-RegExp inputs
package.json Adds modern package exports, TypeScript support, build scripts, and development dependencies
index.js Adds JSDoc documentation, TypeScript type annotations, and exports additional utility functions
eslint.config.mts New ESLint configuration file with modern flat config format
README.md Updates documentation with badges, corrected flag ordering, and improved examples
.prettierrc New Prettier configuration for code formatting
.npmrc New npm configuration with lockfile and versioning settings
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test/index.js Outdated
});

describe('non-RegExps', () => {
it('should throwfor strings', () => {
Copy link

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the test description. 'throwfor' should be 'throw for'.

Suggested change
it('should throwfor strings', () => {
it('should throw for strings', () => {

Copilot uses AI. Check for mistakes.
@aheckmann aheckmann merged commit 1978ee0 into main Aug 13, 2025
3 checks passed
@aheckmann aheckmann deleted the more branch August 13, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants