feat(rag): Milvus support configure database name#978
Merged
LearningGp merged 4 commits intoagentscope-ai:mainfrom Mar 26, 2026
Merged
feat(rag): Milvus support configure database name#978LearningGp merged 4 commits intoagentscope-ai:mainfrom
LearningGp merged 4 commits intoagentscope-ai:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
7ae8f64 to
cf21ef8
Compare
LearningGp
requested changes
Mar 24, 2026
...agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/MilvusStore.java
Outdated
Show resolved
Hide resolved
...agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/MilvusStore.java
Show resolved
Hide resolved
...agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/MilvusStore.java
Outdated
Show resolved
Hide resolved
...agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/MilvusStore.java
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Milvus database selection support to the RAG “simple” MilvusStore so callers can target a specific Milvus database (and optionally create it) instead of always operating on the default DB.
Changes:
- Add
databaseName(and optionaldatabaseProperties) toMilvusStorebuilder and propagate it into Milvus SDK requests. - Ensure the configured database exists (create if missing) and switch the client to that database during initialization.
- Extend unit tests to cover builder options and database-related initialization paths via mocks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| agentscope-extensions/agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/MilvusStore.java | Adds database name/properties support, database existence checks, and passes databaseName through Milvus requests. |
| agentscope-extensions/agentscope-extensions-rag-simple/src/test/java/io/agentscope/core/rag/store/MilvusStoreTest.java | Adds builder/config tests and mock-based tests for database initialization scenarios. |
...agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/MilvusStore.java
Outdated
Show resolved
Hide resolved
...agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/MilvusStore.java
Show resolved
Hide resolved
...agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/MilvusStore.java
Show resolved
Hide resolved
...tscope-extensions-rag-simple/src/test/java/io/agentscope/core/rag/store/MilvusStoreTest.java
Show resolved
Hide resolved
...tscope-extensions-rag-simple/src/test/java/io/agentscope/core/rag/store/MilvusStoreTest.java
Show resolved
Hide resolved
cf21ef8 to
57ebc84
Compare
Contributor
Author
|
@LearningGp Thanks for your review! I have submitted the new code, primarily with the following changes:
|
LearningGp
requested changes
Mar 25, 2026
...agentscope-extensions-rag-simple/src/main/java/io/agentscope/core/rag/store/MilvusStore.java
Outdated
Show resolved
Hide resolved
81dd2e7 to
e7bf9ab
Compare
Contributor
Author
|
@LearningGp I have updated the java docs, thanks for your review again! |
e7bf9ab to
13b782c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.11
Description
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)