Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@LearningGp thx for review this pr for support oltp headers #351 |
LearningGp
requested changes
Mar 24, 2026
| assertTrue(false, "Headers map should be immutable"); | ||
| } catch (UnsupportedOperationException e) { | ||
| // Expected behavior - map is immutable | ||
| assertTrue(true); |
Collaborator
There was a problem hiding this comment.
Suggest using assertThrows here.
| * @param headers Map of header names to values | ||
| * @return This builder | ||
| */ | ||
| public Builder otlpHeaders(java.util.Map<String, String> headers) { |
Collaborator
There was a problem hiding this comment.
Prefer import statements for consistency with the rest of the project.
| * @param value The header value (e.g., "Basic dXNlcjpwYXNz") | ||
| * @return This builder | ||
| */ | ||
| public Builder addOtlpHeader(String key, String value) { |
Collaborator
There was a problem hiding this comment.
Suggest adding a null check here.
| * @param value The header value (e.g., "Basic dXNlcjpwYXNz") | ||
| * @return This builder | ||
| */ | ||
| public Builder addOtlpHeader(String key, String value) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(studio): add OTLP headers support for authentication
Add support for configuring OTLP headers in agentscope-extensions-studio
to enable authentication with external tracing systems like Langfuse.
Changes:
This closes #351 by allowing users to configure authentication headers
when reporting trace data via OTLP to systems requiring authentication.
Example usage for Langfuse: