Skip to content

fix: unbind ShutdownStateSaver on ReActAgent.close() to prevent memory leak #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sikisama wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −2
Open

fix: unbind ShutdownStateSaver on ReActAgent.close() to prevent memory leak #2384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3841,8 +3841,9 @@ public static Builder builder() {

@Override
public void close() {
// No-op for the core ReActAgent. Subclasses / wrappers (HarnessAgent) may release
// additional resources here.
// Release the ShutdownStateSaver registered in the constructor so that ephemeral /
// per-call agent instances are not retained by GracefulShutdownManager.stateSavers.
shutdownManager.unbindStateSaver(this);
}

// ==================== Builder ====================
Expand Down
16 changes: 16 additions & 0 deletions agentscope-core/src/main/java/io/agentscope/core/shutdown/GracefulShutdownManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,22 @@ public void bindStateSaver(Agent agent, ShutdownStateSaver saver) {
stateSavers.put(agent.getAgentId(), saver);
}

/**
* Remove the {@link ShutdownStateSaver} previously registered for the given agent.
*
* <p>Must be called from {@link io.agentscope.core.ReActAgent#close()} (or equivalent
* lifecycle hook) so that ephemeral / per-call agent instances do not accumulate
* indefinitely in {@link #stateSavers}.
*
* @param agent the agent whose saver should be removed; no-op if {@code null}
*/
public void unbindStateSaver(Agent agent) {
if (agent == null) {
return;
}
stateSavers.remove(agent.getAgentId());
}

/**
* Check whether the agent was previously interrupted by shutdown, and clear the flag.
*
Expand Down