feat(harness): support ordered async memory writes#2381
Open
March-77 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
oss-maintainer
approved these changes
Jul 24, 2026
oss-maintainer
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Looks good.
Automated review by "github-manager-bot"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2334
Problem / root cause
MemoryFlushMiddlewareandMemoryMaintenanceMiddlewareappend LLM-backed work withconcatWith, so an otherwise completed agent call holds the session gate until memory extraction and consolidation finish. A naive fire-and-forget subscription would remove that latency but could reorder writes for concurrent turns and lose accepted work during shutdown.Changes
MemoryConfig.ExecutionMode.ASYNCas an opt-in while retainingBLOCKINGas the compatibility defaultHarnessAgent.close()before workspace resources closeUser impact
Latency-sensitive streaming and orchestration can configure
.executionMode(MemoryConfig.ExecutionMode.ASYNC)so the agent Flux completes without waiting for memory LLM calls. Writes for the same isolation key stay ordered. Existing applications retain blocking completion behavior unless they opt in.Tests
mvn -pl agentscope-harness -am -Djacoco.skip=true -Dtest=MemoryConfigTest,MemoryOperationSchedulerTest,MemoryMaintenanceAsyncTest -Dsurefire.failIfNoSpecifiedTests=false test— 13 passedmvn -pl agentscope-harness -DskipTests spotless:check— passed@TempDircleanup errors reproduced in the session-tree mirror path tracked by [Bug]: LocalFilesystemPersonalAssistantExampleTest flaky JUnit @TempDir cleanup race with session-tree-mirror thread #2251 / PR fix(harness): drain session-tree-mirror on HarnessAgent.close #2301, with no assertion failures from this changeCompatibility / risk
BLOCKINGremains the default. Async mode requires applications to closeHarnessAgentduring shutdown; close drains all accepted operations. The scheduler serializes work only within an isolation key, so unrelated users/sessions are not globally bottlenecked.