feat(harness): support per-subagent compaction config#2378
Open
March-77 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
oss-maintainer
approved these changes
Jul 24, 2026
oss-maintainer
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Looks good.
Automated review by "github-manager-bot"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2325.
Declarative subagents could only use their own default compaction behavior because
SubagentDeclarationhad no compaction option and the declared-subagent factory did not propagate the parent setting.This change:
SubagentDeclaration.Builder.compaction(CompactionConfig)for per-subagent configuration;User impact
Callers can configure a declaratively registered subagent with an independent compaction strategy while other subagents continue to inherit the parent behavior.
Tests
mvn -pl agentscope-harness -am -Dtest="HarnessAgentTest,SubagentDeclarationPhaseATest" -Dsurefire.failIfNoSpecifiedTests=false test(44 tests passed)Compatibility and risk
The new builder method is additive. Existing declarations keep inheritance semantics, so no migration is required. The change is limited to local declared-subagent construction; remote task declarations are unaffected.