Skip to content

fix(SkillFileSystemHelper): fix单个技能存在则不保存其他技能 #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
superjvjkdf wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(SkillFileSystemHelper): fix单个技能存在则不保存其他技能 #1049

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3adb04c
fix(SkillFileSystemHelper): 修改覆盖行为为跳过已存在目录
superjvjkdf Mar 26, 2026
a494050
Merge branch 'main' into main
superjvjkdf Mar 26, 2026
9b89ba6
fix(SkillFileSystemHelper): fix单测
superjvjkdf Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions agentscope-core/src/main/java/io/agentscope/core/skill/util/SkillFileSystemHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,8 @@ public static boolean saveSkills(Path baseDir, List<AgentSkill> skills, boolean
return false;
}

int size = skills.size();
int saveCount = 0;
try {
for (AgentSkill skill : skills) {
String skillName = skill.getName();
Expand All @@ -182,7 +184,7 @@ public static boolean saveSkills(Path baseDir, List<AgentSkill> skills, boolean
if (!force) {
logger.info(
"Skill directory already exists and force=false: {}", skillName);
return false;
continue; // Skip to the next skill if force=false
} else {
logger.info("Overwriting existing skill directory: {}", skillName);
deleteDirectory(skillDir);
Expand Down Expand Up @@ -215,10 +217,15 @@ public static boolean saveSkills(Path baseDir, List<AgentSkill> skills, boolean
}
}

saveCount++;
logger.info("Successfully saved skill: {}", skillName);
}
boolean allSaved = (size == saveCount);
if (!allSaved) {
logger.warn("Not all skills were saved. Saved {} of {}", saveCount, size);
}

return true;
return allSaved;
} catch (IOException e) {
logger.error("Failed to save skills", e);
throw new RuntimeException("Failed to save skills", e);
Expand Down
Loading