Skip to content

feat(session): Improve mysql session sql#1006

Merged
LearningGp merged 2 commits intoagentscope-ai:mainfrom
guanxuc:improve-mysql-session
Mar 26, 2026
Merged

feat(session): Improve mysql session sql#1006
LearningGp merged 2 commits intoagentscope-ai:mainfrom
guanxuc:improve-mysql-session

Conversation

@guanxuc
Copy link
Contributor

@guanxuc guanxuc commented Mar 20, 2026

AgentScope-Java Version

1.0.11

Description

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@guanxuc guanxuc requested a review from a team March 20, 2026 14:59
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...io/agentscope/core/session/mysql/MysqlSession.java 66.66% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

guanxuc added 2 commits March 24, 2026 21:53
- Use DATETIME instead of TIMESTAMP for mysql field
- Use TRUNCATE instead of DELETE from table
@guanxuc guanxuc force-pushed the improve-mysql-session branch from 85f2535 to 189f3ba Compare March 24, 2026 14:07
@guanxuc
Copy link
Contributor Author

guanxuc commented Mar 24, 2026

@LearningGp Thanks for your good advice, I have updated the code and the java docs. Keep both clearAllSessions and truncateAllSessions and deprecated clearAllSessions method.

@guanxuc guanxuc requested a review from LearningGp March 24, 2026 14:11
Copy link
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp merged commit 7fa3143 into agentscope-ai:main Mar 26, 2026
6 checks passed
@guanxuc guanxuc deleted the improve-mysql-session branch March 26, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants