rename ErrPersistenceRetry to ErrVersionConflict to reflect the actual behavior - #560
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoJul 28, 2026
Conversation
The error is only returned on an optimistic-concurrency version mismatch. Rename it for that behavior so other retryable errors don't get folded into it (but should introduce their own error name).
Haven Xia (HavenXia)
force-pushed
the
version-conflict-rename
branch
from
July 28, 2026 03:40
df32fa5 to
dcbe067
Compare
Julian Gutierrez Oschmann (juli4n)
merged commit Jul 28, 2026
60d484b
into
agent-substrate:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error is only returned on an optimistic-concurrency version mismatch. Rename it for that behavior so other retryable errors don't get folded into it (but should introduce their own error name).
Followup for post-merge comment in #535