[ add ] Algebra.Definitions.Central plus Consequences for Identity and Zero
#2873
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmckinna
requested review from
JacquesCarette,
MatthewDaggitt and
Taneb
and removed request for
MatthewDaggitt
This was referenced Nov 12, 2025
JacquesCarette
requested changes
Nov 18, 2025
Contributor
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
This is a 90% approve, with picky feedback.
| ```agda | ||
| binomial-expansion : Associative _∙_ → _◦_ DistributesOver _∙_ → | ||
| ∀ w x y z → ((w ∙ x) ◦ (y ∙ z)) ≡ ((((w ◦ y) ∙ (w ◦ z)) ∙ (x ◦ y)) ∙ (x ◦ z)) | ||
| identity⇒central : Identity e _∙_ → Central _∙_ e |
Contributor
There was a problem hiding this comment.
why does this appear twice in the CHANGELOG?
Contributor
Author
There was a problem hiding this comment.
Perhaps this is a misunderstanding on my part, but the separation of Algebra.Consequences into Base, Setoid, and Propositional, means that if we add a new lemma to (the API offered by) Setoid, then we also add a new lemma to the propositional API, so each one gets a CHANGELOG entry?
Contributor
Author
There was a problem hiding this comment.
Tangentially, hence #2874 ... which I stumbled over while writing this PR.
Co-authored-by: Jacques Carette <[email protected]>
Taneb
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifted out of #2863 for low-effort review and merging?